Smarty Forum Index Smarty
WARNING: All discussion is moving to https://reddit.com/r/smarty, please go there! This forum will be closing soon.

[PATCH] _compile_if_tag support Class::function()

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs
View previous topic :: View next topic  
Author Message
jablko
Smarty Rookie


Joined: 07 Apr 2006
Posts: 6

PostPosted: Sat Jun 24, 2006 4:56 am    Post subject: [PATCH] _compile_if_tag support Class::function() Reply with quote

http://cgi.sfu.ca/~jdbates/tmp/smarty/200606230/patch

It is important for me to call functions like the following in {if} tags:


{if GalleryUtilities::isCallback()}


Unfortunately Smarty currently complains: unidentified token '::isCallback()'

This patch fixes _compile_if_tag to support functions like Class::function()

Many thanks - Jack
Back to top
View user's profile Send private message
boots
Administrator


Joined: 16 Apr 2003
Posts: 5611
Location: Toronto, Canada

PostPosted: Sat Jun 24, 2006 7:26 am    Post subject: Reply with quote

hmmm. I know that this sort of addition has been vetoed in the past, but I can see the reason for it. I'll have to look at the patch more closely and hopefully monte or messju will comment. In the meantime, your patch doesn't follow the normal Smarty coding conventions for whitespace. I actually prefer your style but I think it would be better if the patch followed Smarty's standards more closely.
Back to top
View user's profile Send private message
Prikkeldraad
Smarty n00b


Joined: 20 May 2008
Posts: 1

PostPosted: Tue May 20, 2008 2:13 pm    Post subject: Reply with quote

I think this patch or alike is a must have for smarty. These class functions are used more and more. I can't understand why someone would vote against this.

Have monte or messju already looked at it is and what is the status for this patch?

And this should not only work in IF statements but as well in a normal function call.
Back to top
View user's profile Send private message
Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP